Dan Kenigsberg has posted comments on this change.
Change subject: Caps: Include glusterfs packages
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/caps.py
Line 372: elif getos() == OSName.DEBIAN and python_apt:
Line 373: KEY_PACKAGES = {'qemu-kvm': 'qemu-kvm', 'qemu-img':
'qemu-utils',
Line 374: 'vdsm': 'vdsmd', 'spice-server':
'libspice-server1',
Line 375: 'libvirt': 'libvirt0', 'mom': 'mom'}
Line 376: GLUSTER_PACKAGES = {'glusterfs-client': 'glusterfs-client',
I don't get it - you do not have the same keys here and in the rpm-based part.
We'd like this to be a portability layer, so that Engine should not care if
it's RPM or DEB.
Maybe the mapping is impossible - but it does not seem that there's an attempt
here.
Line 377: 'glusterfs-common': 'glusterfs-common',
Line 378: 'glusterfs-dbg': 'glusterfs-dbg',
Line 379: 'glusterfs-server': 'glusterfs-server',
Line 380: 'libglusterfs-dev': 'libglusterfs-dev',
--
To view, visit http://gerrit.ovirt.org/11138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
