Mark Wu has posted comments on this change. Change subject: Fix checking bonding options for missing bonds. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 739: 'valid bonding option' % key) Line 740: except ValueError: Line 741: raise ConfigNetworkError(ne.ERR_BAD_BONDING, 'Error parsing ' Line 742: 'bonding options: %r' % bondingOptions) Line 743: I prefer to add a static options list in vdsm code. The benefit of it is simple and the ability of further validation. For one bonding mode, not all keys under '/sys/class/net/bondX/bonding/' are valid. So we can divide the options by bonding mode. How do you like it? Line 744: Line 745: @contextmanager Line 746: def validationBond(bonding): Line 747: bond_created = False -- To view, visit http://gerrit.ovirt.org/12701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I023a5bb8a52719559bb9d4716f25e0cba8b3530b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
