Mark Wu has posted comments on this change.

Change subject: spec: use the fedora systemd macros
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 532: %systemd_post vdsmd.service
Line 533: %else
Line 534: if [ "$1" -eq 1 ] ; then
Line 535:     /bin/systemctl enable vdsmd.service >/dev/null 2>&1 || :
Line 536:     /bin/systemctl enable vdsm-restore-net-config.service >/dev/null 
2>&1 || :
any reason not enable vdsm-restore-net-config.service by default?
Line 537:     /bin/systemctl daemon-reload >/dev/null 2>&1 || :
Line 538: fi
Line 539: exit 0
Line 540: %endif


--
To view, visit http://gerrit.ovirt.org/12285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76857a6b9ae1a945511f359333735b9497c5e2b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to