Ayal Baron has posted comments on this change. Change subject: BZ890983 - allow dumpStorageTable to handle images with multiple leaf volumes ......................................................................
Patch Set 1: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-03-05 11:26:41 +1000 Line 4: Commit: Mark Huth <[email protected]> Line 5: CommitDate: 2013-03-05 11:26:41 +1000 Line 6: Line 7: BZ890983 - allow dumpStorageTable to handle images with multiple leaf volumes Commit message should take the following form: Patch summary Detailed explanation Bug-Url: https://bugzilla.redhat.com/XXXXXX Change-Id: .. Signed-off-by: .. Line 8: Line 9: Change-Id: Ifa932a47a91caa1a8284ea58678367ca77ed2d9a .................................................... File vdsm/dumpStorageTable.py.in Line 128: self.imagesList[imageDom] = self._buildVolumesChain(leafvols, vollen, Line 129: volParents, sd, Line 130: image) Line 131: Line 132: def _buildVolumesChain(self, leafvols, vollen, volParents, sd, image): Since you (rightfully) removed the use of vollen, please get rid of it all over Line 133: Line 134: volChain = [] Line 135: for leafvol in leafvols: Line 136: # insert an empty 'volume' if there are multiple chains (to differentiate them in the final table) Line 133: Line 134: volChain = [] Line 135: for leafvol in leafvols: Line 136: # insert an empty 'volume' if there are multiple chains (to differentiate them in the final table) Line 137: if volChain: volChain.insert(0,'') please split into 2 lines Line 138: Line 139: volChain.insert(0,leafvol) Line 140: next = leafvol Line 141: while next in volParents.keys(): -- To view, visit http://gerrit.ovirt.org/12703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa932a47a91caa1a8284ea58678367ca77ed2d9a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Huth <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
