Federico Simoncelli has posted comments on this change.
Change subject: [wip] Implement extendVolume in fileSD/Volume.
......................................................................
Patch Set 2: (1 inline comment)
> Federico: I think that the work to expose this command is already complete
I didn't look much into it but it seems that you are right. Although there's a
small issue that you should take care of in the fileVolume.py module.
....................................................
File vdsm/storage/fileVolume.py
Line 630: misc.ddWatchCopy("/dev/zero", volPath,
Line 631: vars.task.aborting, size-currentSize,
currentSize)
Line 632: else:
Line 633: # for sparse files we can just truncate to the correct
size
Line 634: with open(volPath, "a") as f:
I have the feeling that we have two different issues here. One is that having
the fd open in the vdsm process might exposed the daemon to a D-state anyway
(even though we're not doing IO so it might not be relevant). The second thing
is that the truncate operation is executed in a different process (which might
be already there) and which probably doesn't have the file descriptor. The oop
object is already exposing createSparseFile which does a truncate but the name
doesn't look right (here) so we might want to rename it.
Line 635:
oop.getProcessPool(dom.sdUUID).os.ftruncate(f.fileno(),
--
To view, visit http://gerrit.ovirt.org/12713
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d73fd9e7727d9112db05ab892771b37d81152e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Richard Marston <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Richard Marston <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
