Saggi Mizrahi has posted comments on this change. Change subject: Logging: config logging in new process of remoteFileHandler ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/storage/remoteFileHandler.py Line 33: Line 34: import misc Line 35: import fileUtils Line 36: import zombieReaper Line 37: from vdsm import constants The if was only added for testing, if testing works then we can remove it. In any case I don't like the fact that I keep seeing people referencing constants. Line 38: Line 39: # Crabs are known for their remote process calls Line 40: LENGTH_STRUCT_FMT = "Q" Line 41: LENGTH_STRUCT_LENGTH = calcsize(LENGTH_STRUCT_FMT) -- To view, visit http://gerrit.ovirt.org/9182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
