Dan Kenigsberg has posted comments on this change. Change subject: gluster: Handling Attribute error in Python 2.6 ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) Thanks. Please backport this fix to ovirt-3.2 branch! .................................................... File vdsm/gluster/cli.py Line 31: ) Line 32: Line 33: Line 34: if hasattr(etree, 'ParseError'): Line 35: _etreeExceptions = (etree.ParseError, AttributeError, ValueError) I find this tuple assignment a bit awkward. I'd feel more comfortable if you defined if hasattr(etree, 'ParseError'): ParseError = etree.ParseError else: ParseError = SyntaxError and use it later. But I suppose that having a quick fix for el6 is more important than this debate. Line 36: else: Line 37: _etreeExceptions = (SyntaxError, AttributeError, ValueError) Line 38: Line 39: -- To view, visit http://gerrit.ovirt.org/12752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c33b34ce11473636365ea094e267c5424c7255 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
