Mark Wu has posted comments on this change.
Change subject: netinfo: there may be up to one network attached directly to an
Iface
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/netinfo.py
Line 476: network = self.getBridgelessNetworkForIface(iface)
Line 477: if network is not None:
Line 478: return network
Line 479: else:
Line 480: return self.getBridgedNetworkForIface(iface)
I have improved it in v3 as per your suggestion.
getBridge{d,less}NetworkForIface is reserved for future use.
Thanks!
Line 481:
Line 482: def getBridgelessNetworks(self):
Line 483: """ Return all bridgless networks."""
Line 484: for network, netdict in self.networks.iteritems():
--
To view, visit http://gerrit.ovirt.org/9737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80c47d0f0df70de73993ef0c09f69cbf882f6629
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
