Zhou Zheng Sheng has posted comments on this change.
Change subject: Makefile.am: ignore false positive pyflakes lvm.py
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File Makefile.am
Line 71: check-local:
Line 72: find . -path './.git' -prune -type f -o \
Line 73: -name '*.py' -o -name '*.py.in' | xargs $(PYFLAKES) |\
Line 74: xargs -r || xargs -I {} bash -c \
Line 75: 'if grep $(SKIP_PYFLAKES_ERR) {} ; then continue {} ;
fi'
I would like to propose
SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
'lv' from line .*"
check-local:
find . -path './.git' -prune -type f -o \
-name '*.py' -o -name '*.py.in' | xargs $(PYFLAKES) | \
grep -w -v $(SKIP_PYFLAKES_ERR) | \
while read LINE; do echo "$$LINE"; false; done
Line 76: $(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in'
\
Line 77: $(PEP8_WHITELIST)
Line 78: @if test -f .gitignore; then \
Line 79: for i in `git ls-files \*.in`; do \
--
To view, visit http://gerrit.ovirt.org/12700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cdeb0c28c1ee5dc3a18a7688ae60fe641f9a6c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
