Ayal Baron has posted comments on this change.

Change subject: Prefetch domains when connecting a storage server.
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 2223:         """
Line 2224:         vars.task.setDefaultException(se.GetFloppyListError("%s" % 
spUUID))
Line 2225:         return self.getIsoList(spUUID=spUUID, extension='vfd')
Line 2226: 
Line 2227:     def __getSDTypefindMethod(self, domType):
s/f/F/
Line 2228:         # TODO: make sd.domain_types a real dictionary and remove 
this.
Line 2229:         # Storage Domain Types find methods
Line 2230:         SDTypeFindMethod = {sd.NFS_DOMAIN: nfsSD.findDomain,
Line 2231:                             sd.FCP_DOMAIN: blockSD.findDomain,


....................................................
File vdsm/storage/sdc.py
Line 139:         else:
Line 140:             try:
Line 141:                 dom = findMethod(sdUUID)
Line 142:             except se.StorageDomainDoesNotExist:
Line 143:                 self.log.error("prefetch domain %s not found", sdUUID,
s/prefetch//
Line 144:                                exc_info=True)
Line 145:             else:
Line 146:                 return dom
Line 147: 


Line 150:         import glusterSD
Line 151:         import localFsSD
Line 152:         import nfsSD
Line 153: 
Line 154:         self.log.error("looking for unfetched domain %s", sdUUID)
s/unfetched//
Line 155: 
Line 156:         # The order is somewhat important, it's ordered
Line 157:         # by how quickly get can find the domain. For instance
Line 158:         # if an nfs mount is unavailable we will get stuck


--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f2b19a566c659bac30a318d17cef929e0b2575b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to