Dan Kenigsberg has posted comments on this change. Change subject: gluster: VDSM Gluster verbs to manage UFO/swift configuration ......................................................................
Patch Set 14: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/gluster/cli.py Line 920: try: Line 921: config.readfp(open(config_file)) Line 922: except IOError as e: Line 923: errMsg = "%s: %s" % (e.errno, e.strerror) Line 924: raise ge.GlusterSwiftConfigOpenFailedException(err=[errMsg]) please avoid str() in favor of unicode(). str() explodes on ಕನ್ನಡ characters. Line 925: Line 926: return config Line 927: Line 928: -- To view, visit http://gerrit.ovirt.org/10864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie966fb515275a0768f67cbbe2055a07002355327 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
