Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
......................................................................
Patch Set 17: (2 inline comments)
....................................................
File vdsm/Makefile.am
Line 140: vdsm-restore-net-config.init.in \
Line 141: vdsm-restore-net-config.service \
Line 142: vdsm-store-net-config.in \
Line 143: vdsm-sysctl.conf \
Line 144: vdsm.rwtab.in \
It's a Dan request.
Line 145: vdsmd.8.in \
Line 146: vdsmd.init.in \
Line 147: vdsmd.service \
Line 148: $(NULL)
....................................................
File vdsm.spec.in
Line 484: %{buildroot}/lib/systemd/systemd-vdsm-reg
Line 485: install -Dm 0644 vdsm_reg/vdsm-reg.service \
Line 486: %{buildroot}%{_unitdir}/vdsm-reg.service
Line 487: install -Dm 0644 vdsm/vdsm-modules-load.d.conf \
Line 488: %{buildroot}%{_sysconfdir}/modules-load.d/vdsm.conf
It will continue with the same permission, it's just a formal parameter to
install.
Line 489: %else
Line 490: # Install the SysV init scripts
Line 491: install -Dm 0755 vdsm/vdsmd.init %{buildroot}%{_initrddir}/vdsmd
Line 492: install -Dm 0755 vdsm_reg/vdsm-reg.init
%{buildroot}%{_initrddir}/vdsm-reg
--
To view, visit http://gerrit.ovirt.org/11718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I026ff658482ccefbdcc384785cdec10cf934b7d9
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
