Jason Dillaman has posted comments on this change.
Change subject: vdsm: Add additional exception handling within vmChannels.py
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/vmChannels.py
Line 118: try:
Line 119: events = self._epoll.poll(1)
Line 120: except IOError as err:
Line 121: # We don't want to log a quite common error
Line 122: if err.errno is not errno.EINTR:
Style: why use "is" (identity) over "==" (value) comparison?
Line 123: self.log.exception("IOError on epoll.poll(1)")
Line 124: except:
Line 125: self.log.exception("Exception on epoll.poll(1)")
Line 126: else:
--
To view, visit http://gerrit.ovirt.org/13093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Jason Dillaman <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
