Eduardo has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/sdc.py
Line 131: self._syncroot.notifyAll()
Line 132:
Line 133: def _findDomain(self, sdUUID):
Line 134: try:
Line 135: findMethod = self.knownSDs[sdUUID]
No need for.
We are only leaking uuid:storage_type (i.e. small int) pairs.
The dictionary is no so big and SD that are bot used anymore will not referred
by the engine.
I think that comparing this small leak vs the complexity introduced by the
removal, the leak (only until the next vdsm restart) is preferible.
Line 136: except KeyError:
Line 137: self.log.error("looking for unfetched domain %s", sdUUID)
Line 138: return self._findUnfetchedDomain(sdUUID)
Line 139: else:
--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f2b19a566c659bac30a318d17cef929e0b2575b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
