Eduardo has posted comments on this change.
Change subject: getAllVolumes returns partially deleted volumes too.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 172: if vImg not in res[volName]['imgs']:
Line 173: res[volName]['imgs'].insert(0, vImg)
Line 174: if parentVol != sd.BLANK_UUID:
Line 175: try:
Line 176: imgIsUnknown = vImg not in res[parentVol]['imgs']
['imgs'] is a list because the order is important.
If more than one image was found, the 1st one is the image template.
Line 177: except KeyError:
Line 178: log.warning("Found broken img %s, orphan volume
%s/%s, "
Line 179: "parent %s", vImg, sdUUID, volName,
parentVol)
Line 180: else:
--
To view, visit http://gerrit.ovirt.org/12546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gicko...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
