Antoni Segura Puimedon has uploaded a new change for review. Change subject: Fix misleading method parameter name bridge->device. ......................................................................
Fix misleading method parameter name bridge->device. Since this method servers for any kind of device, not just bridges, it is more correct not to refer to bridge as the parameter it takes. Change-Id: Ie63c783cfde43dee3e470e7eb4a8b1811833e52e Signed-off-by: Antoni S. Puimedon <[email protected]> --- M vdsm/API.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/13136/1 diff --git a/vdsm/API.py b/vdsm/API.py index 0046b57..aefdab5 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -619,14 +619,14 @@ imageID=paramImageID, volumeID=paramVolumeID, device='disk') - def _getNetworkIp(self, bridge): + def _getNetworkIp(self, device): try: - ip = netinfo.getaddr(bridge) + ip = netinfo.getaddr(device) except: ip = config.get('addresses', 'guests_gateway_ip') if ip == '': ip = '0' - self.log.info('network %s: using %s', bridge, ip) + self.log.info('network %s: using %s', device, ip) return ip def snapshot(self, snapDrives): -- To view, visit http://gerrit.ovirt.org/13136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie63c783cfde43dee3e470e7eb4a8b1811833e52e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
