Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Add additional exception handling within vmChannels.py
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm/vmChannels.py
Line 117: """ Wait for an epoll event and handle channels' timeout. """
Line 118: try:
Line 119: events = NoIntrPoll(self._epoll.poll, 1)
Line 120: except:
Line 121: self.log.exception("Exception on epoll.poll(1)")
ok true.
Line 122: raise
Line 123: else:
Line 124: for (fileno, event) in events:
Line 125: self._handle_event(fileno, event)
Line 132: def run(self):
Line 133: """ The listener thread's function. """
Line 134: self.log.info("Starting VM channels listener thread.")
Line 135: self._quit = False
Line 136: try:
Dan suggested to move it outside, we had it initially inside :/
Line 137: while not self._quit:
Line 138: self._wait_for_events()
Line 139: except:
Line 140: self.log.exception("Unhandled exception caught in vm
channels "
--
To view, visit http://gerrit.ovirt.org/13093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Jason Dillaman <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
