Vered Volansky has posted comments on this change. Change subject: vdsm: propagate MountError when mount fails ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/storage/storageServer.py Line 205: except OSError as e: Line 206: if e.errno != errno.EEXIST: Line 207: raise Line 208: Line 209: try: I see what you mean, but I don't see a clash between the two. The other patch is not sufficient because the MountError will not be propagated to the engine, so the bug will not be solved unless this patch is enclosed at least in the other. I also think that since the two don't clash and there's a working solution it should also be merged, unless it's nacked on it's own merrits. Line 210: self._mount.mount(self.options, self._vfsType) Line 211: except MountError as e: Line 212: try: Line 213: os.rmdir(self._getLocalPath()) -- To view, visit http://gerrit.ovirt.org/10966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f36b3ea18690d7cf53439e5a0342b1495f4f181 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
