Jarod.w has posted comments on this change.
Change subject: Optimize netinfo.networks.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/netinfo.py
Line 89: 'red': { 'iface': 'red', 'bridged': False } }
Line 90: """
Line 91: nets = {}
Line 92: conn = libvirtconnection.get()
Line 93: allNets = ((net, net.name()) for net in conn.listAllNetworks(0))
The api listAllNetworks doesn't exist in libvirt 0.9.10-21.el6_3.6 required by
vdsm, so, you should update the libvirt version required by vdsm.
Line 94: vdsmNets = ((net[0],
Line 95: net[1][len(LIBVIRT_NET_PREFIX):])
Line 96: for net in allNets if
net[1].startswith(LIBVIRT_NET_PREFIX))
Line 97: for net, netname in vdsmNets:
--
To view, visit http://gerrit.ovirt.org/13159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd332819363c4399335358686e19d6a1dc3b45e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Jarod.w <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
