Dan Kenigsberg has posted comments on this change.
Change subject: setupNetworks: Improve behavior under lots of nets.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 1316: ifdown(nic)
Line 1317: configWriter.removeNic(nic)
Line 1318: ifup(nic)
Line 1319:
Line 1320: del bondings[bond]
I am afraid that's going to explode with your change - we have to work with a
copy of the dictionary.
Line 1321:
Line 1322:
Line 1323: def _buildBondOptions(bondName, bondings, _netinfo):
Line 1324: logger = logging.getLogger("_buildBondOptions")
Line 1414: if 'remove' in networkAttrs:
Line 1415: del networks[network]
Line 1416: del libvirt_nets[network]
Line 1417: else:
Line 1418: networksAdded.add(network)
here too.
Line 1419:
Line 1420: # Remove bonds with 'remove' attribute
Line 1421: _removeBondings(bondings, configWriter)
Line 1422:
--
To view, visit http://gerrit.ovirt.org/13171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34a07f0ea33407a566bcc9c82e5ba6ca0c0701a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
