Dan Kenigsberg has posted comments on this change.
Change subject: Add migration network support.
......................................................................
Patch Set 3: Verified
(1 inline comment)
we've just reviewed this patch with ALona's code. We had one dubious libvirt
crash, but besides that, the proper arguments are passed to libvirt and qemu
below.
....................................................
File vdsm/libvirtvm.py
Line 478: self._vm.conf['_migrationParams']['dstqemu']
Line 479: else:
Line 480: muri = 'tcp://%s' % self.remoteHost
Line 481:
Line 482: self._vm.log.debug('starting migration to %s', duri)
would be nicer to log 'muri'
Line 483:
Line 484: t = MigrationDowntimeThread(self._vm, int(self._downtime),
Line 485: self._vm._migrationTimeout()
/ 2)
Line 486:
--
To view, visit http://gerrit.ovirt.org/11795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17d760c7421e765454e13ee5b7d8be23e6b7e383
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
