Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Try to reconnect on vmchannel after errors ......................................................................
Patch Set 12: (1 inline comment) .................................................... File vdsm/guestIF.py Line 98: self._sock.close() Line 99: self._sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) Line 100: self._sock.setblocking(0) Line 101: # Save the socket's fileno because a call to fileno() fails if the Line 102: # socket is closed before GuestAgent.stop() is called. do we really want to keep a stale fd of a closed socket? when we get to use it, it may point to an unrelated file or socket. Line 103: self._sock_fd = self._sock.fileno() Line 104: return self._sock_fd Line 105: Line 106: @staticmethod -- To view, visit http://gerrit.ovirt.org/11977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b9b9418e39558d45c97e9545bc9ecc4935f004e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Jason Dillaman <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
