Aravinda VK has posted comments on this change.
Change subject: gluster: VDSM Gluster verbs to manage UFO/swift configuration
......................................................................
Patch Set 17: (2 inline comments)
....................................................
File vdsm/gluster/swift.py
Line 43: elif configOption in items:
Line 44: return {configOption: items[configOption]}
Line 45: else:
Line 46: errMsg = "%s: Invalid Swift Config option" % configOption
Line 47: raise ge.GlusterSwiftConfigInvalidOptionException(err=[errMsg])
Sorry. I didn't get what benifits we get with that approach
Line 48:
Line 49:
Line 50: def _openSwiftConfigFile(serverType):
Line 51: config = ConfigParser()
Line 57: try:
Line 58: config.readfp(open(config_file))
Line 59: except IOError as e:
Line 60: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror,
e.filename)
Line 61: raise ge.GlusterSwiftConfigOpenFailedException(err=[errMsg])
unicode() will also explode as codes(Not readable when printed/in log file), if
file name is Unicode. I tested with dummy file with Unicode name.
Line 62:
Line 63: return config
Line 64:
Line 65:
--
To view, visit http://gerrit.ovirt.org/10864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie966fb515275a0768f67cbbe2055a07002355327
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
