Dan Kenigsberg has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/caps.py
Line 123: sockets = set()
Line 124: siblings = set()
Line 125: for cpu in cells.getElementsByTagName('cpu'):
Line 126: sockets.add(cpu.getAttribute('socket_id'))
Line 127: siblings.add(cpu.getAttribute('siblings'))
finding a set of unique core_id seems more direct approach. Any reason not to
use it?
Line 128:
Line 129: topology = {'sockets': len(sockets),
Line 130: 'cores': len(siblings),
Line 131: 'threads': cpus}
....................................................
File vdsm.spec.in
Line 113: Requires: python
Line 114: # Update the qemu-kvm requires when block_stream will be included
Line 115: Requires: qemu-kvm >= 2:0.12.1.2-2.295.el6_3.4
Line 116: Requires: qemu-img >= 2:0.12.1.2-2.295.el6_3.4
Line 117: Requires: libvirt >= 0.10.2-18.el6_4.1
needs rebase - we already have
libvirt >= 0.10.2-18.el6_4.2
Line 118: Requires: iscsi-initiator-utils >= 6.2.0.872-15
Line 119: Requires: device-mapper-multipath >= 0.4.9-52
Line 120: Requires: e2fsprogs >= 1.41.12-11
Line 121: Requires: kernel >= 2.6.32-279.9.1
--
To view, visit http://gerrit.ovirt.org/11709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e4a08cfcde6fb2e1ce4cf10478af72217c20ba5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000373
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
