Dan Kenigsberg has submitted this change and it was merged. Change subject: Reduce calling to ethtool. ......................................................................
Reduce calling to ethtool. Currently we do separate ethtool device object retrieval for getaddr, getnetmask and getipv6addrs. This patch unifies it into a single getIpInfo while leaving the api for the separatemethods available. Furthermore, it simplifies the get method by moving the device specific methods to their own methods. As a bonus, this has about 25% perf when creating a netinfo.NetInfo instance. Change-Id: Ic2c161b112865ef5cd4842fe70f26a3eeab1c3dd Signed-off-by: Antoni S. Puimedon <[email protected]> --- M lib/vdsm/netinfo.py 1 file changed, 57 insertions(+), 42 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2c161b112865ef5cd4842fe70f26a3eeab1c3dd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
