Dan Kenigsberg has posted comments on this change.
Change subject: Prefetch domains when connecting a storage server.
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2307: "Could not connect to storageServer",
exc_info=True)
Line 2308: status, _ = self._translateConnectionError(err)
Line 2309: else:
Line 2310: status = 0
Line 2311: doms = self.__prefetchDomains(domType, conObj)
Ayal, do you suggest to put a big try-except block within __prefetchDomains()?
Why? Just because it is a new piece of code?
If the new code causes us to fail to fail to prefetch a storage domain, we'd
better notice this on first connect, and not some time in the future.
Line 2312: sdCache.knownSDs.update(doms)
Line 2313:
Line 2314: self.log.debug("knownSDs: %s", sdCache.knownSDs)
Line 2315:
--
To view, visit http://gerrit.ovirt.org/12869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f2b19a566c659bac30a318d17cef929e0b2575b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
