Dan Kenigsberg has submitted this change and it was merged. Change subject: image: placeholder optimization on preallocation ......................................................................
image: placeholder optimization on preallocation When the destination of a copy or move command is an NFS domain we should try to optimize the placeholders creation avoiding unnecessary prezeroing (only relevant case: RAW PREALLOCATED). In such case in the past we were using a TEMPORARY_VOLUME_SIZE to create a placeholder with a temporary size of 10Mb. This is interfering with live storage migration as the following volumes in the chain are inheriting the temporary size inside the qcow header (virtual disk size). With this patch we are instead forcing the creation of the volume as SPARSE as this won't have any side effect on the qcow header. Change-Id: I32811bd45320ef02bfc593a71dfdafc0b0550c7d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910445 Signed-off-by: Federico Simoncelli <[email protected]> --- M vdsm/storage/fileSD.py M vdsm/storage/image.py M vdsm/storage/sd.py 3 files changed, 30 insertions(+), 12 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32811bd45320ef02bfc593a71dfdafc0b0550c7d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
