Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix crash on vm start with netdevs w/out some info
......................................................................
Patch Set 3: (1 inline comment)
And thanks everyone for the reviews.
....................................................
File vdsm/libvirtvm.py
Line 2968: devType = x.getAttribute('type')
Line 2969: mac =
x.getElementsByTagName('mac')[0].getAttribute('address')
Line 2970: alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
Line 2971: if devType == 'hostdev':
Line 2972: name = alias
I thought that for statistical purposes it might be better to have a nic.name
be like the alias for the passed through
devices, but I'm open to change it if somebody has strong objections.
Line 2973: model = 'passthrough'
Line 2974: else:
Line 2975: name =
x.getElementsByTagName('target')[0].getAttribute('dev')
Line 2976: model =
x.getElementsByTagName('model')[0].getAttribute('type')
--
To view, visit http://gerrit.ovirt.org/13540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a90fba21075ab2c7ecb0cb75f14ca07f090829e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Yasny <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
