Ayal Baron has posted comments on this change.
Change subject: Remove unused onlyDataDomains parameter from
getImageDomainsList.
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1667: d = sdCache.produce(sdUUID)
Line 1668: except Exception:
Line 1669: # Pass over invisible active domains
Line 1670: self.log.error("Unexpected error", exc_info=True)
Line 1671: continue
This will return the export domain as well which breaks the API and is a bug.
Line 1672:
Line 1673: imageslist = d.getAllImages()
Line 1674: if imgUUID in imageslist:
Line 1675: domainslist.append(sdUUID)
--
To view, visit http://gerrit.ovirt.org/12926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25fe2714e4c4e832230653cebc87d8da0e81028b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
