Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: fix Vm cleanup routine
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1875: 'message': e.message}}
Line 1876: else:
Line 1877: hooks.after_disk_hotunplug(driveXml, self.conf,
Line 1878: params=params.get('custom',
{}))
Line 1879: self._cleanupDrives()
why are you cleaning up all drives? you should do it *only* for the unplugged
one.
Line 1880:
Line 1881: return {'status': doneCode, 'vmList': self.status()}
Line 1882:
Line 1883: def _readPauseCode(self, timeout):
--
To view, visit http://gerrit.ovirt.org/13610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie355022866d008a83257b1b6e3a4226a07d34c2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
