Mark Wu has uploaded a new change for review. Change subject: Use 'ip link' to get different kinds of interfaces ......................................................................
Use 'ip link' to get different kinds of interfaces It's a little faster than listing the dir '/sys/class/net' Change-Id: Iecc2300963fe1834defb99f5be92b25c0218cf00 Signed-off-by: Mark Wu <[email protected]> --- M tests/netinfoTests.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/13668/1 diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py index 5e0716e..016d68a 100644 --- a/tests/netinfoTests.py +++ b/tests/netinfoTests.py @@ -43,12 +43,12 @@ def testSpeedInvalidNic(self): nicName = 'DUMMYNICDEVNAME' - self.assertTrue(nicName not in netinfo.nics()) + self.assertTrue(nicName not in netinfo.getInterfaces()[0]) s = netinfo.speed(nicName) self.assertEqual(s, 0) def testSpeedInRange(self): - for d in netinfo.nics(): + for d in netinfo.getInterfaces()[0]: s = netinfo.speed(d) self.assertFalse(s < 0) self.assertTrue(s in ETHTOOL_SPEEDS or s == 0) -- To view, visit http://gerrit.ovirt.org/13668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iecc2300963fe1834defb99f5be92b25c0218cf00 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
