Dan Kenigsberg has submitted this change and it was merged. Change subject: shareVolumeRollback() should raise when recovery failed. ......................................................................
shareVolumeRollback() should raise when recovery failed. Engine does not care whether an exception is thrown during rollback, as such exception is caught by task.Task._run() when it is calls the rollback function. Removed try blocks in order to raise exceptions caused by failed volume link removal in other than an inexistent link. Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270 Signed-off-by: Eduardo <[email protected]> --- M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py 2 files changed, 5 insertions(+), 15 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
