Dan Kenigsberg has posted comments on this change.
Change subject: Remove fileUtils.cleanupfiles().
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileVolume.py
Line 200: puuid, exc_info=True)
Line 201:
Line 202: try:
Line 203: self.oop.utils.rmFile(vol_path)
Line 204: self.oop.utils.rmFile(lease_path)
I'm worried more about the removal of Exception here - what if oop throws a
TimeoutError? you change the semantics and do not attempt to call
removeMetadata().
It might be a good thing - but it is not part of this message which is about
inlining fileUtils.cleanupfiles().
Line 205: except OSError as e:
Line 206: eFound = e
Line 207: self.log.error("cannot delete volume %s at path: %s",
self.volUUID,
Line 208: vol_path, exc_info=True)
--
To view, visit http://gerrit.ovirt.org/11425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dbb22ea97b1a6b2d572d21a5c4267fe78759e7f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
