Dan Kenigsberg has posted comments on this change. Change subject: Checking syslog availability before starting vdsm ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 450: local ret_val Line 451: Line 452: python @VDSMDIR@/hooks.pyc before_vdsm_start Line 453: Line 454: shutdown_conflicting_srv && stop_libvirtd_sysv && syslog_available repeat: why not move it to line 474 below? Line 455: ret_val=$? Line 456: if [ $ret_val -ne 0 ] Line 457: then Line 458: return $ret_val -- To view, visit http://gerrit.ovirt.org/13547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60d0537f67da3cf81477760ccb3760a103dc15ac Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
