Dan Kenigsberg has posted comments on this change. Change subject: vdsmd.init.in: removing /var/log/vdsm/libvirt.log ......................................................................
Patch Set 4: I would prefer that you didn't submit this argh, I was not clear. so sorry. I meant that the read variables should (have!) been defined (and documented!) in vdsm/config.py, where you can also give them and empty default. Your solution may be just as good (except the lacking documentation). Please consider mine, though. -- To view, visit http://gerrit.ovirt.org/13728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b777c42b29a747bfdc647af56a0e7d56c16194f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
