Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: vdsm-tool: add service management utilities ......................................................................
Patch Set 3: Looks good to me, but someone else must approve I'm not that familiar with all the init systems so this is just a code review, but I think it looks good. I like this abstraction. You'd almost want this to be a python-libservice or something along those lines. -- To view, visit http://gerrit.ovirt.org/13701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd1cbcf5fd00bb1ec73c5970be012e294b3b4c55 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
