Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: change default migration bandwidth in conf
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File lib/vdsm/config.py.in
Line 56: 'listening before migration begins.'),
Line 57:
Line 58: ('migration_max_bandwidth', '32',
Line 59: 'Maximum bandwidth for migration, in MBps, 0 means
libvirt\'s '
Line 60: 'default: 32MBps or unlimited, depending on the version.'),
Peter, in the bug you mentioned something about the unit.
Is it MiB per second? If so it should be stated correctly and consistently in
the documentation.
Line 61:
Line 62: ('migration_monitor_interval', '10',
Line 63: 'How often (in seconds) should the monitor thread pulse, 0
means '
Line 64: 'the thread is disabled.'),
--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
