Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 14: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2053: # To reduce the race we validate SPM status before and after
retreiving
Line 2054: # the task list.
Line 2055: if spUUID:
Line 2056: self.validateSPM(spUUID)
Line 2057: allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
Each connection for vdsm requests is independent and presist until the result
returns or an error raises. The connection and the request doesn't correlet to
the status of the host and engine wont close the connection base of spm status.
While the thread that sends the getAllTaskList request is running, everything
can run simultaneously.. If the response takes too long, we'll get an network
exception after timeout, engine will get the exception and fail the request.
The seond validation is there only to be sure that before returning the
response vdsm itself didn't change its status.
All I wanted to say is that if the reponse lost in the wire, it'll also react
as expected ..
and the second validation can reduce the race as well... as you mentioned in
your first comment.
Line 2058: if spUUID:
Line 2059: self.validateSPM(spUUID)
Line 2060: return dict(allTasksStatus=allTasksStatus)
Line 2061:
--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel P. Berrange <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
