Federico Simoncelli has posted comments on this change. Change subject: stats: report the domain version ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/storage/domainMonitor.py Line 58: # synchronous operation (e.g.: connectStoragePool, getInfo) Line 59: # we cannot risk to stop and wait for the iso domain to Line 60: # report its prefix (it might be unreachable). Line 61: self.isoPrefix = None Line 62: self.version = 0 It might be better to set this to None and not report the version when the domain is unreachable. Line 63: Line 64: def update(self, st): Line 65: for attr in self.__slots__: Line 66: setattr(self, attr, getattr(st, attr)) -- To view, visit http://gerrit.ovirt.org/13620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88884356eefcd5040deccbf34eab271be8dbc522 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
