Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't user sudo in fuser
......................................................................
Patch Set 1: Fails
For F19 this is not enough, as the following fails:
======================================================================
ERROR: testThreadLeak (storageMailboxTests.SPM_MailMonitorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/celebdor/rpmbuild/BUILD/vdsm-4.10.3/tests/storageMailboxTests.py", line
53, in testThreadLeak
mailer = sm.SPM_MailMonitor(StoragePoolStub(), 100)
File
"/home/celebdor/rpmbuild/BUILD/vdsm-4.10.3/vdsm/storage/storage_mailbox.py",
line 495, in __init__
(rc, out, err) = misc.execCmd(cmd, sudo=False, data=self._outgoingMail)
File "/home/celebdor/rpmbuild/BUILD/vdsm-4.10.3/vdsm/storage/misc.py", line
208, in execCmd
(out, err) = p.communicate(data)
File "/home/celebdor/rpmbuild/BUILD/vdsm-4.10.3/vdsm/storage/misc.py", line
960, in communicate
self.stdin.write(data)
File "/home/celebdor/rpmbuild/BUILD/vdsm-4.10.3/vdsm/storage/misc.py", line
838, in write
self._parent._processStreams()
File "/home/celebdor/rpmbuild/BUILD/vdsm-4.10.3/vdsm/storage/misc.py", line
902, in _processStreams
written = os.write(fd, buff)
OSError: [Errno 32] Broken pipe
-------------------- >> begin captured logging << --------------------
Misc.ThreadPool: DEBUG: Enter - numThreads: 5.0, waitTimeout: 3, maxTasks: 500.0
Storage.MailBox.SpmMailMonitor: DEBUG: SPM_MailMonitor - clearing outgoing
mail, command is: ['dd',
'of=/tmp/tmpVOZj5Z/d34ed30b-9481-4b53-8a9d-19070fb99fe9/mastersd/dom_md/outbox',
'oflag=direct', 'iflag=fullblock', 'conv=notrunc', 'count=1']
Storage.Misc.excCmd: DEBUG: 'dd
of=/tmp/tmpVOZj5Z/d34ed30b-9481-4b53-8a9d-19070fb99fe9/mastersd/dom_md/outbox
oflag=direct iflag=fullblock conv=notrunc count=1 bs=409600' (cwd None)
--------------------- >> end captured logging << ---------------------
I believe the patches that fixed that should maybe be backported as well, and
this rebased on top (or those rebased on top of this). V-1 for visibility.
--
To view, visit http://gerrit.ovirt.org/13810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74842ffda1bc1d5ebb54de5e1933fedd851e745b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
