Mark Wu has posted comments on this change.
Change subject: Use 'ip link' to get different kinds of interfaces
......................................................................
Patch Set 9: (2 inline comments)
Thanks for the good comments!
....................................................
File lib/vdsm/netinfo.py
Line 64: name = match.group('name')
Line 65: ifaceType = match.group('type')
Line 66: link = match.group('link')
Line 67: if ifaceType:
Line 68: if ifaceType == 'tun' or ifaceType == 'dummy':
Done
Line 69: ifaceType = 'fake'
Line 70: interfaces[ifaceType].append(name)
Line 71: elif link == 'ether':
Line 72: interfaces['nic'].append(name)
....................................................
File vdsm/neterrors.py
Line 32:
Line 33: ERR_FAILED_IPLINK = 50
Line 34:
Line 35:
Line 36: class FetchNetworkError(Exception):
Done
Line 37: def __init__(self, errCode, message):
Line 38: self.errCode = errCode
Line 39: self.message = message
--
To view, visit http://gerrit.ovirt.org/13668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecc2300963fe1834defb99f5be92b25c0218cf00
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
