Antoni Segura Puimedon has posted comments on this change.

Change subject: NetReload: Moved addNetwork logic to the configurator
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 116:         if network:
Line 117:             self.configWriter.createLibvirtNetwork(network, False, 
iface)
Line 118:         return iface
Line 119: 
Line 120:     def configureBond(self, network, bonding, nics=None, ipaddr=None,
Done
Line 121:                       netmask=None, mtu=None, gateway=None, 
bridge=None,
Line 122:                       bondingOptions=None, async=False, 
bootproto=None,
Line 123:                       **options):
Line 124:         mtu = self.configWriter.getMaxMtu(nics, mtu)


--
To view, visit http://gerrit.ovirt.org/13268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877eddc07a17f0bdd376df7bab8b19ffe52f72ba
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to