Vinzenz Feenstra has posted comments on this change.
Change subject: agent: XML Character filtering improvement
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/guestIF.py
Line 325: if err.errno == errno.EWOULDBLOCK:
Line 326: pass
Line 327:
Line 328: def _parseLine(self, line):
Line 329: line = _filterXmlChars(line)
I have tried to find an example where this wouldn't be enough. However it seems
it's all really covered by checking only the raw UTF-8 data for invalid XML
characters.
Therefore I have removed that additional check
Line 330: args = json.loads(line.decode('utf8'))
Line 331: args = _filterObject(args)
Line 332: name = args['__name__']
Line 333: del args['__name__']
--
To view, visit http://gerrit.ovirt.org/13809
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21b970c8552b3f238c6bfe9271c5c5a37d40ea4d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
