Aravinda VK has posted comments on this change. Change subject: gluster: Added gluster hooks support ......................................................................
Patch Set 22: (1 inline comment) .................................................... File vdsm/gluster/exception.py Line 397: code = 4500 Line 398: message = "Gluster Hook Exception" Line 399: Line 400: Line 401: class GlusterHookListException(GlusterException): Looks like, ovirt-engine uses these error codes to map respective error messages in UI. If we combine error code of Hook List, Hook enable then it will be very difficult to map the meaningful message in UI for each error types. For example: ovirt-engine patch which will use these error messages. http://gerrit.ovirt.org/#/c/13270/ Line 402: code = 4501 Line 403: message = "List gluster hook failed" Line 404: Line 405: -- To view, visit http://gerrit.ovirt.org/9671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
