Yeela Kaplan has posted comments on this change. Change subject: Remove redundant domStatuses parameter from validateAttachedDomain() ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 1101: domainStatuses = self.getDomains() Line 1102: dom = sdCache.produce(sdUUID) Line 1103: # Avoid domain activation if not owned by pool Line 1104: self.validateAttachedDomain(dom) Line 1105: Since you no longer use domainStatuses in validate, I would move 'domainStatuses = self.getDomains()' here. Line 1106: # Do nothing if already active Line 1107: if domainStatuses[sdUUID] == sd.DOM_ACTIVE_STATUS: Line 1108: return True Line 1109: -- To view, visit http://gerrit.ovirt.org/14012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3daea2fa5928dee18efdf6452b65fbc212eec54 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
