Dan Kenigsberg has posted comments on this change.
Change subject: guestIF: Additional object strings filtering
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/guestIF.py
Line 349:
Line 350: return result
Line 351:
Line 352: def _parseLine(self, line):
Line 353: line = _filterXmlChars(line)
so why is this call still needed?
Line 354: args = json.loads(line.decode('utf8'))
Line 355: args = _filterObject(args)
Line 356: name = args['__name__']
Line 357: del args['__name__']
--
To view, visit http://gerrit.ovirt.org/14126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id64438812a19b25b67b8e50c5c56b0d776c4463e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
