Yeela Kaplan has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1831:
Line 1832: # FIXME: pathListIter() should not return empty records
Line 1833: for dev in multipath.pathListIter(guids):
Line 1834: if ((storageType and dev["devtype"] != storageType) or
Line 1835: (not storageType)):
Done
Line 1836: continue
Line 1837:
Line 1838: pv = pvs.get(dev.get('guid', ""))
Line 1839: if pv is not None:
Line 2771: if dev is None:
Line 2772: self.log.warn("dev %s was not found in %s",
Line 2773: getGuid(pv), pathDict)
Line 2774: continue
Line 2775: if vgInfo["type"] is None:
Done
Line 2776: vgInfo["type"] = dev["devtype"]
Line 2777: elif vgInfo["type"] != dev["devtype"]:
Line 2778: vgInfo["type"] = multipath.DEV_ISCSI
Line 2779:
....................................................
File vdsm/storage/multipath.py
Line 38:
Line 39: import storage_exception as se
Line 40:
Line 41: DEV_FCP = 2
Line 42: DEV_ISCSI = 3
Done
Line 43:
Line 44: MAX_CONF_COPIES = 5
Line 45:
Line 46: TOXIC_CHARS = '()*+?|^$.\\'
Line 354: pathInfo["type"] = DEV_FCP
Line 355:
Line 356: devInfo["paths"].append(pathInfo)
Line 357:
Line 358: if len(devtypes) > 1:
Done
Line 359: devInfo["devtype"] = DEV_ISCSI
Line 360: else:
Line 361: devInfo["devtype"] = devtypes.pop()
Line 362:
--
To view, visit http://gerrit.ovirt.org/13363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
