Aravinda VK has posted comments on this change.
Change subject: gluster: Added gluster hooks support
......................................................................
Patch Set 25: (1 inline comment)
....................................................
File vdsm/gluster/hooks.py
Line 135: enabledFile, disabledFile = _getHookFileNames(glusterCmd,
Line 136: hookLevel.lower(),
hookName)
Line 137: if os.path.exists(enabledFile):
Line 138: logging.warn("Enabled hook file:%s already exists" %
enabledFile)
Line 139: return
this logging is confusing. In the log file no differentiation between vdsm
hooks/gluster hooks.
Use:
log = logging.getLogger("Gluster")
then use log.warn(), log.error() wherever required.
Line 140: try:
Line 141: os.rename(disabledFile, enabledFile)
Line 142: st = os.stat(enabledFile)
Line 143: os.chmod(enabledFile, st.st_mode | stat.S_IEXEC)
--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
