Adam Litke has posted comments on this change. Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) No major objections. Would like to see a few cleanups in the find_schema() path. .................................................... File vdsm_api/vdsmapi.py Line 137: if os.access(path, os.R_OK): Line 138: return path Line 139: else: Line 140: return None Line 141: Is there a way you could adapt the original function to support the gluster schema? Why are you not attempting to support finding the schema file in the local path? Maybe you should install the schema file in the same directory as the vdsm schema. Then you can modify find_schema to take a schema name (with the default being 'vdsmapi-schema'. Line 142: Line 143: _api_info = None Line 144: Line 145: -- To view, visit http://gerrit.ovirt.org/13921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10b51a41d103afcf81cb76c460f3b9821238317 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
