Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm-tool: unify ad-hoc execCmd implementations ......................................................................
Patch Set 4: Verified (1 inline comment) Thanks Antoni. I agree with you that we should move execCmd to vdsm.utils. When I looked at the code, I found the dependencies of execCmd should be moved to vdsm.utils as well. I thought this movement was too big. Now I recognize that moving execCmd to vdsm.utils is actually the right thing to do. So I submit a new patch to move execCmd and its dependencies [1], and use vdsm.utils.execCmd directly in this patch, without modifying PYTHONPATH. [1] http://gerrit.ovirt.org/#/c/14221/ .................................................... File lib/vdsm/tool/load_needed_modules.py.in Line 29: def _exec_command(argv): Line 30: """ Line 31: This function executes a given shell command. Line 32: """ Line 33: rc, out, err = execCmd(argv, raw=True) 'err' here is used in the exception message formatting, so raw=True is better. Line 34: if rc != 0: Line 35: raise Exception("Execute command %s failed: %s" % (argv, err)) Line 36: Line 37: -- To view, visit http://gerrit.ovirt.org/13917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ca64ec5dbfebe5c5090ec8fac46785a538b79d3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
